city_rally_point_receive() 'pcity' should not be nonnull

• Relator: cazfi
• Dono: cazfi
• Tipo: Bugs
• Estado: Fechado
• Componente: General
• Marcos: 3.1.0-beta1 (fechado)
• Prioridade: 9 - Highest
• Gravidade: 5 - Medium
• Resolução: Fixed
• Arquivo: 1

Details

CI build mac-meson complains about the fact that city_rally_point_receive() makes a tautological check against NULL pcity while the parameter is defined nonnull.

I think we have to support NULL pcity there, even though I've not seen any compiler to give an error about NULL passed now that it has been nonnull.

Ticket History (3/4 Histories)

2022-12-16 01:02 Updated by: cazfi

• New Ticket "city_rally_point_receive() 'pcity' should not be nonnull" created

2022-12-16 01:08 Updated by: cazfi

• File 0021-city_rally_point_receive-Remove-nonnull-attribute-fr.patch (File ID: 11111) is attached

2022-12-16 01:09 Updated by: cazfi

• Dono Update from (Nenhum) to cazfi
• Resolução Update from Nenhum to Accepted
• Prioridade Update from 5 - Medium to 9 - Highest

Comentário

As a (macos) build breakage, should be treated as an emergency fix. Will test the attached patch and then push immediately, if seems fine.

2022-12-16 02:44 Updated by: cazfi

• Estado Update from Aberto to Fechado
• Resolução Update from Accepted to Fixed