save_action_ui_name() has potential strcmp(NULL ...) call

• Relator: cazfi
• Dono: cazfi
• Tipo: Bugs
• Estado: Fechado
• Componente: Ruledit and ruleup
• Marcos: 3.0.6 (fechado)
• Prioridade: 5 - Medium
• Gravidade: 5 - Medium
• Resolução: Fixed
• Arquivo: 2

Details

save_action_ui_name() does not check if ui_name for the action is NULL, but passes it to strcmp(). Makes clang analyzer to complain.

Ticket History (3/5 Histories)

2022-12-16 21:15 Updated by: cazfi

• New Ticket "save_action_ui_name() has potential strcmp(NULL ...) call" created

2022-12-19 05:42 Updated by: cazfi

• File 0045-rulesave-Fix-clang-analyzer-warning-about-strcmp-NUL.patch (File ID: 11161) is attached

2022-12-19 05:42 Updated by: cazfi

• File 0032-rulesave-Fix-clang-analyzer-warning-about-strcmp-NUL.patch (File ID: 11162) is attached

2022-12-19 05:43 Updated by: cazfi

• Dono Update from (Nenhum) to cazfi
• Resolução Update from Nenhum to Accepted

Comentário

The same patch probably would apply to all branches, but I made them different - the master one adds an assert, which stable branched don't.

2022-12-29 18:43 Updated by: cazfi

• Estado Update from Aberto to Fechado
• Resolução Update from Accepted to Fixed