Tíquete #46306

pf_attack_possible() int-conversion warning

: 2022-12-18 08:08 Última Atualização: 2023-01-02 12:32

Relator:
Dono:
Tipo:
Estado:
Fechado
Componente:
Marcos:
Prioridade:
5 - Medium
Gravidade:
5 - Medium
Resolução:
Fixed
Arquivo:
2

Details

Testing with gcc-13 in c2x (likely c23) standard mode: S3_1 pf_attack_possible() assignment from is_non_allied_city_tile() to non_allied_city gives error about converting pointer to int.

Ticket History (3/7 Histories)

2022-12-18 08:08 Updated by: cazfi
  • New Ticket "pf_attack_possible() int-conversio warning" created
2022-12-18 08:08 Updated by: cazfi
  • Summary Updated
2022-12-20 13:11 Updated by: None
Comentário

The problem is that unlike their name suggest is_..._city_tile() functions return a pointer, not a boolean. That has worked under earlier C standard versions.

2022-12-29 11:14 Updated by: cazfi
  • Dono Update from (Nenhum) to cazfi
  • Resolução Update from Nenhum to Accepted
  • Marco Update from (Nenhum) to 3.0.6 (fechado)
Comentário

No S2_6 patch yet - have to confirm if one is needed. Review period for later branches running anyway.

2023-01-02 12:32 Updated by: cazfi
  • Estado Update from Aberto to Fechado
  • Resolução Update from Accepted to Fixed

Editar

Please login to add comment to this ticket » Login