sdl2: First create_tech_info() 't1' assignment is a dead one

• Relator: cazfi
• Dono: cazfi
• Tipo: Bugs
• Estado: Fechado
• Componente: SDL2-client
• Marcos: 3.0.7 (fechado)
• Prioridade: 5 - Medium
• Gravidade: 5 - Medium
• Resolução: Fixed
• Arquivo: 3

Details

As clang analyzer reports, 't1' assignment in create_tech_info() before the while loop is a dead one. It gets overwritten on the first round of the loop. Further, the assignment might cause NULL dereference if there's no sub targets (even index 0 sub target is NULL).

Ticket History (3/6 Histories)

2023-03-21 02:59 Updated by: cazfi

• New Ticket "sdl2: First create_tech_info() 't1' assignment is a dead one" created

2023-03-21 03:15 Updated by: cazfi

• File 0031-sdl2-Fix-tech-help-NULL-dereference.patch (File ID: 11908) is attached

2023-03-21 03:15 Updated by: cazfi

• File 0016-sdl2-Fix-tech-help-NULL-dereference.patch (File ID: 11909) is attached

2023-03-21 03:15 Updated by: cazfi

• File 0004-sdl-2-Fix-tech-help-NULL-dereference.patch (File ID: 11910) is attached

2023-03-21 03:16 Updated by: cazfi

• Dono Update from (Nenhum) to cazfi
• Resolução Update from Nenhum to Accepted

Comentário

Attached even S2_6 patch, handling also sdl-client

2023-03-26 17:13 Updated by: cazfi

• Estado Update from Aberto to Fechado
• Resolução Update from Accepted to Fixed