Tíquete #41041

Define of TreeView_GetItemRect error

: 2020-12-10 13:17 Última Atualização: 2021-05-10 06:06

Relator:
Dono:
Tipo:
Estado:
Fechado
Componente:
(Nenhum)
Marcos:
(Nenhum)
Prioridade:
5 - Medium
Gravidade:
5 - Medium
Resolução:
Fixed
Arquivo:
Nenhum
Vote
Score: 0
No votes
0.0% (0/0)
0.0% (0/0)

Details

In include/commctrl.h, line 4587-4590:

#define TreeView_GetItemRect( w, i, p, c )				\
  (*(HTREEITEM *)((p) = (i)),						\
    (BOOL)(SNDMSG ((w), TVM_GETITEMRECT, (c), (LPARAM)((LPRECT)(p))))	\
  )
line 4588
  (*(HTREEITEM *)((p) = (i)),
is wrong; should be:
  ((*(HTREEITEM *)(p) = (i)),

Ticket History (3/3 Histories)

2020-12-10 13:17 Updated by: royqh1979
  • New Ticket "Define of TreeView_GetItemRect error" created
2021-04-14 04:34 Updated by: keith
  • Dono Update from (Nenhum) to keith
  • Resolução Update from Nenhum to Accepted
  • Details Updated
Comentário

Reply To royqh1979

In include/commctrl.h, line 4587-4590:
...
line 4588

   (*(HTREEITEM *)((p) = (i)),
  is wrong ...

Thanks. I agree with your assessment, and with your proposed correction. You could have laid the report out better, (as I have done now), and had you provided a suitable patch, it might have made it into WSL-5.4.2. As it is now, I've corrected it in my local repository copy, and will push it for inclusion in the next release.

How would you like the attribution to appear, in the ChangeLog?

2021-05-10 06:06 Updated by: keith
  • Estado Update from Aberto to Fechado
  • Resolução Update from Accepted to Fixed
Comentário

I committed #0c111ac; since you didn't offer a timely response to my request for attribution details, the ChangeLog will reflect only my own details, as committer.

Attachment File List

No attachments

Editar

Please login to add comment to this ticket » Login