Freeciv

+ if (context->tile == NULL) {
+ /* RPT_CERTAIN: Can't be. No tile to contain it.
+ * RPT_POSSIBLE: A tile city like that may exist but not be passed. */
+ return prob_type == RPT_CERTAIN;
+ }

Umh. Should that be '!=' ? Now you return TRUE for RPT_CERTAIN when tile is NULL.

Should is_req_knowable() have handling for Small Wonders equivalent to Great Wonder handling? Would depend on game.ruleset wonder_visibility.small_wonders

"A city ... must not stay ..."

Might be because I'm not native speaker, but to me that sounds like the city should not be a moving one.

Reply To cazfi

Umh. Should that be '!=' ? Now you return TRUE for RPT_CERTAIN when tile is NULL.

That's how is_req_knowable() works for now: if it sees NULL for a necessary context field in RPT_POSSIBLE, it supposes that the player just does not know what is it; in RPT_CERTAIN, it supposes that it is just NULL so the result is TRI_MAYBE -> FALSE so it is known. If it is wrong, it's not the patch to change it.

Should is_req_knowable() have handling for Small Wonders equivalent to Great Wonder handling? Would depend on game.ruleset wonder_visibility.small_wonders

The problem is that we can't be sure whose city may be on a tile we don't see. We need to recurse by all players that is likely behind "just an obvious fact" (that I think is what this function does) and is more "can sometimes be deduced with an adequate effort".

"A city ... must not stay ..." Might be because I'm not native speaker, but to me that sounds like the city should not be a moving one.

OK, neither a native speaker but I'll try to reword.

Reply To ihnatus

Reply To cazfi

Umh. Should that be '!=' ? Now you return TRUE for RPT_CERTAIN when tile is NULL.

That's how is_req_knowable() works for now: if it sees NULL for a necessary context field in RPT_POSSIBLE, it supposes that the player just does not know what is it; in RPT_CERTAIN, it supposes that it is just NULL so the result is TRI_MAYBE -> FALSE so it is known. If it is wrong, it's not the patch to change it.

Ok. Thanks for the explanation.

Should is_req_knowable() have handling for Small Wonders equivalent to Great Wonder handling? Would depend on game.ruleset wonder_visibility.small_wonders

The problem is that we can't be sure whose city may be on a tile we don't see. We need to recurse by all players that is likely behind "just an obvious fact" (that I think is what this function does) and is more "can sometimes be deduced with an adequate effort".

Ok.

Thanks for the new version. Please leave also a comment when attaching files - osdn does not send notifications when there's just an attachment added. (I see you had attached the file just two minutes after I had commented, but that was enough for me not to see it)

Are there any other patches of yours currently waiting maintainer actions?