Tíquete #45267

generate_packets.py: Generated code call 'are_cm_parameters_equal()'

: 2022-07-29 23:45 Última Atualização: 2022-08-23 23:59

Relator:
Dono:
Tipo:
Estado:
Fechado
Componente:
Marcos:
Prioridade:
5 - Medium
Gravidade:
5 - Medium
Resolução:
Fixed
Arquivo:
1

Details

When a packet definition containing cm_parameter is added to packets.def (there isn't any at the moment), compile fails for are_cm_parameters_equal() calls in packets_gen.c. I guess it should be cm_are_parameters_equal()

Ticket History (3/7 Histories)

2022-07-29 23:45 Updated by: cazfi
  • New Ticket "generate_packets.py: Generated code call 'are_cm_parameters_equal()'" created
2022-07-30 00:02 Updated by: cazfi
Comentário

Reply To cazfi

When a packet definition containing cm_parameter is added to packets.def

Example is in WIP patch attached to #45268

2022-07-30 18:08 Updated by: alienvalkyrie
Comentário

Typo in the generate_packets type parsing code. I'm a bit busy, so I haven't tested the patch in action, but it should work. If not, I'll have to take a closer look.

(Edited, 2022-07-30 18:08 Updated by: alienvalkyrie)
2022-08-17 17:52 Updated by: cazfi
  • Marco Update from (Nenhum) to 3.2.0
Comentário

It works.

2022-08-22 10:22 Updated by: cazfi
  • Dono Update from (Nenhum) to cazfi
  • Resolução Update from Nenhum to Accepted
2022-08-23 23:59 Updated by: cazfi
  • Estado Update from Aberto to Fechado
  • Resolução Update from Accepted to Fixed

Editar

Please login to add comment to this ticket » Login